add Zone.root to get root zone directly #601

JiaLiPassion · 2017-01-15T05:38:18Z

add runOutsideOfCurrentZone method just like runOutsideAngular so we can run under rootZone or fork a new zone under rootZone.

Zone.current.fork({name: 'testZone'}).run(function() {
        Zone.runOutsideOfCurrentZone(() => {
          expect(Zone.current.name).toEqual('<root>');
        });
      });

The motivation is to run some async code inside the zoneSpec's callback. Without the runOutsideOfCurrentZone method, such async call will cause infinite loop.
for example:

Zone.current.fork({
  name: 'testZone', 
  onScheduleTask: function(delegate, currentZone, targetZone, task) {
     asyncLog(task);
     return delegate.scheduleTask(targetZone, task);
  }
});

asyncLog will cause infinite loop, now we can

Zone.current.fork({
  name: 'testZone', 
  onScheduleTask: function(delegate, currentZone, targetZone, task) {
     Zone.runOutsideCurrentZone(() => {
        asyncLog(task);
    });
     return delegate.scheduleTask(targetZone, task);
  }
});

mhevery

I am sorry, but I don't see the need for this API. I am fine with adding root property, but the rest seems just sugar.

My concern is that new APIs need to be maintained, and documented. Personally my philosophy is to just give the bare minimum and have the developer build on top of that.

mhevery · 2017-01-23T20:08:35Z

lib/zone.ts

@@ -564,6 +571,27 @@ const Zone: ZoneType = (function(global: any) {
      }
    }

+    static get rootZone(): AmbientZone {


I am fine with this API, but I would rename it to root

mhevery · 2017-01-23T20:09:29Z

lib/zone.ts

+      return zone;
+    }
+
+    static runOutsideOfCurrentZone(


I think this API gives too much complexity to the user. Same can be achieved by:

Zone.root.fork(zoneSpec).run(....)

So I don't see the need to have it.

JiaLiPassion · 2017-01-23T20:22:44Z

@mhevery , Ok, got it,I have modified the PR, please review

googlebot added the cla: yes label Jan 15, 2017

JiaLiPassion force-pushed the outside branch from 94fc3e5 to 3230f9b Compare January 15, 2017 05:44

xtianjohns mentioned this pull request Jan 16, 2017

'Uncaught TypeError: Cannot set property stack of [object Object] which has only a getter' with Angular #427

Closed

mhevery reviewed Jan 23, 2017

View reviewed changes

JiaLiPassion force-pushed the outside branch from 3230f9b to d2f58b2 Compare January 23, 2017 23:06

JiaLiPassion changed the title ~~add runOutsideOfCurrentZone just like runOutsideOfAngular~~ add Zone.root to get root zone directly Jan 24, 2017

add Zone.root api

108ec24

JiaLiPassion force-pushed the outside branch from d2f58b2 to 108ec24 Compare January 24, 2017 01:22

mhevery merged commit 9818139 into angular:master Feb 7, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add Zone.root to get root zone directly #601

add Zone.root to get root zone directly #601

JiaLiPassion commented Jan 15, 2017 •

edited

Loading

mhevery left a comment

mhevery Jan 23, 2017

mhevery Jan 23, 2017

JiaLiPassion commented Jan 23, 2017 •

edited

Loading

add Zone.root to get root zone directly #601

add Zone.root to get root zone directly #601

Conversation

JiaLiPassion commented Jan 15, 2017 • edited Loading

mhevery left a comment

Choose a reason for hiding this comment

mhevery Jan 23, 2017

Choose a reason for hiding this comment

mhevery Jan 23, 2017

Choose a reason for hiding this comment

JiaLiPassion commented Jan 23, 2017 • edited Loading

JiaLiPassion commented Jan 15, 2017 •

edited

Loading

JiaLiPassion commented Jan 23, 2017 •

edited

Loading